fix(cli): warn on stale warehouse reports in portfolio truth mode#54
Merged
Conversation
…h mode (F2) Per the F2 decision (keep both truth artifacts live), surface the dual-artifact liveness gap at generation time. `audit report --portfolio-truth` dispatches to _run_portfolio_truth_mode, which scans the workspace and publishes portfolio-truth-latest.json but never regenerates the legacy audit-report-<username>-*.json warehouse file — and it can't cheaply, since the truth pipeline doesn't run the GitHub audit that produces warehouse data. Notion OS's external-signal-sync reads that warehouse file, so it silently goes stale (live: 06-03 vs truth 06-07). Add _warn_if_warehouse_report_stale: after publishing truth, warn (with the exact remediation command) when the newest warehouse report is missing or older than WAREHOUSE_REPORT_STALE_DAYS (7). Self-announcing every truth run, so the gap can't rot unnoticed; complements the cross-system-smoke C2 check that catches it at smoke time. Tests cover missing / stale / fresh. 46 portfolio-truth tests pass, ruff clean, no new mypy errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
audit report --portfolio-truthwhen the latest warehouse audit report is missing or staleVerification
.venv/bin/python -m pytest -q -p no:cacheprovider tests/test_portfolio_truth.py.venv/bin/ruff check src/ tests/